Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classname #161

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Update classname #161

merged 2 commits into from
Oct 26, 2023

Conversation

tobeycodes
Copy link
Member

@tobeycodes tobeycodes commented Oct 26, 2023

Description of the Change

Update the root class name to make theme.json changes possible.

If you add this to your theme.json the css is applied to the block classname wp-block-safe-svg-svg-icon so this does not get applied to the block.

      "safe-svg/svg-icon": {
        "border": {
          "color": "var(--wp--preset--color--gray-200)",
          "radius": "8px",
          "style": "solid",
          "width": "1px"
        },
      }

How to test the Change

Apply the theme.json change above against develop and this branch to see the difference

Changelog Entry

Added support theme.json block changes

Credits

@tobeycodes

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@tobeycodes tobeycodes requested a review from a team as a code owner October 26, 2023 17:54
@tobeycodes tobeycodes requested review from Sidsector9 and removed request for a team October 26, 2023 17:54
@jeffpaul jeffpaul requested a review from dkotter October 26, 2023 18:51
includes/blocks/safe-svg/edit.js Outdated Show resolved Hide resolved
includes/blocks/safe-svg/register.php Outdated Show resolved Hide resolved
@dkotter dkotter added this to the 2.3.0 milestone Oct 26, 2023
@dkotter dkotter merged commit 48bf43b into 10up:develop Oct 26, 2023
11 checks passed
@tobycodes
Copy link

Description of the Change

Update the root class name to make theme.json changes possible.

If you add this to your theme.json the css is applied to the block classname wp-block-safe-svg-svg-icon so this does not get applied to the block.

      "safe-svg/svg-icon": {
        "border": {
          "color": "var(--wp--preset--color--gray-200)",
          "radius": "8px",
          "style": "solid",
          "width": "1px"
        },
      }

How to test the Change

Apply the theme.json change above against develop and this branch to see the difference

Changelog Entry

Added support theme.json block changes

Credits

@tobycodes

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

I think I was wrongly tagged in this :)

Great work though.

@dkotter dkotter modified the milestones: 2.3.0, 2.2.2 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants